Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model versioning support #784

Merged
merged 10 commits into from
Feb 1, 2021
Merged

Add model versioning support #784

merged 10 commits into from
Feb 1, 2021

Conversation

brandenchan
Copy link
Contributor

The latest FARM version allows for specifying the model version when downloading a model from HuggingFace's Model Hub. This allows for the same model versioning to be done when initializing a FARM or Transformers Reader. Solves #712

@brandenchan brandenchan self-assigned this Jan 28, 2021
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also support it for the other models in Haystack (DPR, RAG, Summarization, EmbeddingRetriever) or do we miss any changes on FARM side for this?

@brandenchan
Copy link
Contributor Author

Can we also support it for the other models in Haystack (DPR, RAG, Summarization, EmbeddingRetriever) or do we miss any changes on FARM side for this?

Yup sure!

Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandenchan brandenchan merged commit 1dc74c7 into master Feb 1, 2021
@brandenchan brandenchan deleted the model_versioning branch February 1, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants