Update tutorials to use Elasticsearch, new Retrievers #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanaysoni
force-pushed
the
update-tutorials
branch
from
be4611c
to
55ec831
Compare
tholor
requested changes
Apr 29, 2020
There was a problem hiding this comment.
Looking good. Thanks for working on this!
I have added some minor changes in the notebooks.
Before we merge we should:
- Make naming of tutorial 1 & 3 more similar (I would suggest Basic-QA-Pipeline for both)
- Update the .py files (same content as notebooks)
- Make the launch of elasticsearch optional in the .py version of Tutorial 1 (e.g. bool flag)
tanaysoni
changed the title
tanaysoni
force-pushed
the
update-tutorials
branch
from
093688b
to
29f7e24
Compare
tholor
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.