chore: update sentence transformers import error message #7906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
requested review from
dfokina and
davidsbatista
and removed request for
a team
anakin87
commented
Jun 20, 2024
| @@ -11,7 +11,7 @@ | |||
| from haystack.utils import ComponentDevice, expit | |||
| from haystack.utils.auth import Secret, deserialize_secrets_inplace | |||
|
|
|||
| with LazyImport(message="Run 'pip install scikit-learn \"sentence-transformers>=2.2.0\"'") as sas_import: | |||
| with LazyImport(message="Run 'pip install \"sentence-transformers>=2.3.0\"'") as sas_import: | |||
There was a problem hiding this comment.
unrelated: we don't directly depend on scikit-learn (which is a core dependency of sentence-transformers).
Pull Request Test Coverage Report for Build 9600530110Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
While helping a user in #7850, I discovered that we are suggesting to install
sentence-transformers>=2.2.0,while the parameter
trust_remote_code(introduced in Haystack in #7356) is only compatible with >=2.3.0 (UKPLab/sentence-transformers#2272).Proposed Changes:
How did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.