Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file upload API #808

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Fix file upload API #808

merged 2 commits into from
Feb 5, 2021

Conversation

tanaysoni
Copy link
Contributor

@tanaysoni tanaysoni commented Feb 4, 2021 •
edited
Loading

With the introduction of the Preprocessor, some cleaning steps like remove_whitespace, remove_empty_lines were moved out of the file converters. This breaks the file upload API with the current Haystack version.

This PR adapts the file upload API to use the Preprocessor alongside the fie converters.

@tanaysoni tanaysoni requested a review from tholor February 4, 2021 15:11
@tanaysoni tanaysoni changed the title WIP: Fix file upload API Fix file upload API Feb 4, 2021
tholor
tholor approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Just wondering if we should use the occasion to add the split params in the API (see comment).

rest_api/controller/file_upload.py Show resolved Hide resolved
@tanaysoni tanaysoni requested a review from tholor February 5, 2021 09:41
tholor
tholor approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanaysoni tanaysoni merged commit f95b70d into master Feb 5, 2021
@tanaysoni tanaysoni deleted the fix-file-upload-api branch February 5, 2021 11:17
@tanaysoni tanaysoni mentioned this pull request Feb 5, 2021
Closed
@MathiasKrill
Copy link

HI, it works well now - thank you for fixing so fast , thats the spirit !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tanaysoni @MathiasKrill @tholor