Add support for parallel paths in Pipeline #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oryx1729
commented
Mar 10, 2021
| @@ -560,7 +561,7 @@ def run(self, **kwargs): | |||
|
|
|||
| if self.join_mode == "concatenate": | |||
| document_map = {} | |||
| for input_from_node, _ in inputs: | |||
| for input_from_node in inputs: | |||
There was a problem hiding this comment.
The stream IDs from predecessor nodes were erroneously passed here.
oryx1729
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
Pipelinesupports parallel paths having exactly one node. For instance, the following graph will work with the existingPipelinewhere nodesCandDare parallel paths.However, when having more than 1 node in a parallel path is not supported. For instance, in the following graph, where
C/EandDare in separate parallel paths.This PR adds supports for the second type of graphs with multiple nodes in a parallel path.