WIP: Fix execution of Pipelines with parallel nodes #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #688, the
Pipelinewas extended to support executing graphs that have parallel nodes.This worked well until there was a case with a graph having both "branch"(having multiple output streams) node and parallel nodes. In that case, the complete graph did not get executed, resulting in partial results.
Here's the graph:
When the
QueryRouterreturnsoutput_2, then the pipeline executed only one of the two graph retriever nodes and returned the results.This PR refactor the
run()method which resolves the issue.