Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for FAISSDocumentStore #999

Merged
merged 2 commits into from Apr 27, 2021
Merged

Conversation

oryx1729
Copy link
Contributor

@oryx1729 oryx1729 commented Apr 26, 2021

This PR adds a test case to verify if the documents are loaded correctly from a saved FAISS Document Store and introduces the tmp_path fixture.

@oryx1729 oryx1729 requested a review from tholor April 26, 2021 15:28
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oryx1729 oryx1729 merged commit 8a57f6b into master Apr 27, 2021
@oryx1729 oryx1729 deleted the update-faiss-load-test branch April 27, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants