-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General maintenance #4
Conversation
go.mod
Outdated
@@ -1,16 +1,35 @@ | |||
module github.com/deepshore/docker-machine-driver-proxmoxve | |||
|
|||
go 1.16 | |||
go 1.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im github workflow wurde die Version auf 1.20 angehoben, warum hier nur 1.19?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah danke !
|
||
// Basic Authentication for Proxmox VE | ||
Host string // Host to connect to | ||
Port string // Port to connect to (default 8006) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warum kein int?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
die uri wird in zeile 113 als string zusammengebaut.
da gibts vorab leider noch keine sinnvolle prüfung auf plausibilität.
Co-authored-by: tr-nextevolution <83716342+tr-nextevolution@users.noreply.github.com>
…hine-driver-proxmox-ve into general_maintenance
This overall maintenance change does following:
Tests
I have tested this module with following setup: