Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General maintenance #4

Merged
merged 31 commits into from
Nov 27, 2023
Merged

General maintenance #4

merged 31 commits into from
Nov 27, 2023

Conversation

selamanse
Copy link
Contributor

@selamanse selamanse commented Nov 24, 2023 •
edited
Loading

This overall maintenance change does following:

  • Rewrites the module to use a newer pve6,7 and 8 compliant api implementation https://github.com/luthermonson/go-proxmox
  • Discards of unsused functionality for Deepshore
  • Introduces some unit testing
  • Introduces makefile for convenient overall build, test, deploy workflow
  • Adds Deepshore to License
  • Cleanup of code (lint, duplicates, wait and request efficiency)
  • uses rancher compose instead of even older docker compose module
  • Removes unsafe/deprecated crypto libs

Tests

I have tested this module with following setup:

  • docker-machine version 0.16.2-gitlab.21, build 77bd8f58
  • mac m1
  • PVE 7.4-17
  • given ansible playbook was also tested to create the base clone template

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2023 •
edited
Loading

Test Results

4 tests   4 ✔️  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 1ae1c49.

♻️ This comment has been updated with latest results.

@selamanse selamanse marked this pull request as ready for review November 25, 2023 18:56
tr-nextevolution
tr-nextevolution approved these changes Nov 27, 2023
View reviewed changes
go.mod Outdated
@@ -1,16 +1,35 @@
module github.com/deepshore/docker-machine-driver-proxmoxve

go 1.16
go 1.19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im github workflow wurde die Version auf 1.20 angehoben, warum hier nur 1.19?

Copy link
Contributor Author

@selamanse selamanse Nov 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah danke !

driver.go

// Basic Authentication for Proxmox VE
Host string // Host to connect to
Port string // Port to connect to (default 8006)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warum kein int?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

die uri wird in zeile 113 als string zusammengebaut.
da gibts vorab leider noch keine sinnvolle prüfung auf plausibilität.

driver.go Outdated Show resolved Hide resolved
selamanse and others added 3 commits November 27, 2023 09:38
@selamanse @tr-nextevolution
Update driver.go
ebc3049 
Co-authored-by: tr-nextevolution <83716342+tr-nextevolution@users.noreply.github.com>
@selamanse
Update go.mod to 1.20
75314f3
@selamanse
Merge branch 'general_maintenance' of github.com:deepshore/docker-mac…
1ae1c49 
…hine-driver-proxmox-ve into general_maintenance
@selamanse selamanse merged commit 4a7b4c7 into master Nov 27, 2023
3 checks passed
@selamanse selamanse deleted the general_maintenance branch May 7, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tr-nextevolution tr-nextevolution tr-nextevolution approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@selamanse @tr-nextevolution