Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promises and callbacks hang forever on conflict #519

Closed
alanhoff opened this issue Feb 15, 2020 · 2 comments
Closed

Promises and callbacks hang forever on conflict #519

alanhoff opened this issue Feb 15, 2020 · 2 comments

Comments

@alanhoff
Copy link

Whenever a client needs to run a merge strategy, any callback or promise related to the merged record will hang forever. This code can be used to replicate the problem, one just need to open two tabs running the same code and will notice that one of the tabs will simply stop logging tx done after a few seconds.

const {DeepstreamClient} = require('@deepstream/client');
const client = new DeepstreamClient('ws://localhost:6020');

client.login({}, async () => {
  const record = client.record.getRecord('hello-world');

  while (true) {
    await record.setWithAck({time: Date.now()});

    console.log('tx done');
  }
});

This is also related to #504

@yasserf
Copy link
Contributor

yasserf commented May 10, 2020

Fixed! Woo.

@yasserf
Copy link
Contributor

yasserf commented May 10, 2020

This is now commited and is just pending change logs and a few more other small fixes to round up this release.

Thanks again for raising and apologies for the delay!

@yasserf yasserf closed this as completed May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants