fix: adding tests and use null for non existant records

src/permission/rule-application.ts

@@ -260,7 +260,7 @@ export default class RuleApplication {
     }
     const recordData = this.recordsData[this.params.name]
     if (typeof recordData !== UNDEFINED) {
-      return recordData ? recordData._d : {}
+      return recordData ? recordData._d : null
     }
     this.loadRecord(this.params.name)
   }

test/permission/config-permission-handler-basicSpec.ts

@@ -221,6 +221,52 @@ describe('permission handler applies basic permissions referencing their own dat
     })).toBe(false)
   })
 
+  it('checks against existing data for non-existant record reads', (next) => {
+    const permissions = getBasePermissions()
+
+    permissions.record['nonExistingRecord'] = {
+      read: 'oldData.xyz === "hello"'
+    }
+
+    const message = {
+      topic: C.TOPIC.RECORD,
+      action: C.RECORD_ACTIONS.READ,
+      name: 'nonExistingRecord',
+    }
+
+    const callback = function (error, result) {
+      expect(lastError()).toContain('Cannot read property \'xyz\' of null')
+      expect(result).toBe(false)
+      next()
+    }
+
+    testPermission(permissions, message, 'user', null, callback)
+  })
+
+  it('checks against existing data for non-existant list reads', (next) => {
+    const permissions = getBasePermissions()
+
+    permissions.record['nonExistingRecord'] = {
+      read: 'oldData.indexOf("hello") !== -1'
+    }
+
+    const message = {
+      topic: C.TOPIC.RECORD,
+      action: C.RECORD_ACTIONS.READ,
+      name: 'nonExistingRecord',
+    }
+
+    const callback = function (error, result) {
+      expect(lastError()).toContain('Cannot read property \'indexOf\' of null')
+      expect(error).toBe(C.AUTH_ACTIONS.MESSAGE_PERMISSION_ERROR)
+      expect(result).toBe(false)
+      next()
+    }
+
+    testPermission(permissions, message, 'user', null, callback)
+
+  })
+
   it('deals with broken messages', next => {
     const permissions = getBasePermissions()
 

test/record/record-handlerSpec.ts

@@ -309,7 +309,7 @@ describe('record handler handles messages', () => {
     recordHandler.handle(client.socketWrapper, M.recordDelete)
 
     services.cache.get(M.recordDelete.name, (error, record) => {
-      expect(record).toEqual(undefined)
+      expect(record).toEqual(null)
     })
   })
 

test/test-mocks/storage-mock.ts

@@ -74,10 +74,10 @@ export default class StorageMock {
     const value = this.values[key]
 
     if (this.nextGetWillBeSynchronous === true) {
-      callback(this.nextOperationWillBeSuccessful ? null : 'storageError', value ? Object.assign({}, value) : undefined)
+      callback(this.nextOperationWillBeSuccessful ? null : 'storageError', value ? Object.assign({}, value) : null)
     } else {
       this.getTimeout = setTimeout(() => {
-        callback(this.nextOperationWillBeSuccessful ? null : 'storageError', value ? Object.assign({}, value) : undefined)
+        callback(this.nextOperationWillBeSuccessful ? null : 'storageError', value ? Object.assign({}, value) : null)
       }, 25)
     }
   }