Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminate unauthenticated connections after a timeout #226

Closed
WolframHempel opened this issue Jun 24, 2016 · 0 comments
Closed

Terminate unauthenticated connections after a timeout #226

WolframHempel opened this issue Jun 24, 2016 · 0 comments
Assignees
@yasserf
Labels
feature

Comments

@WolframHempel
Copy link
Member

WolframHempel commented Jun 24, 2016 •
edited by yasserf

Deepstream allows every client to establish a connection, but keeps it in a quarantine state until it is authenticated. Currently, unauthenticated connections are kept indefinitely. This might lead to an attack angle of clogging deepstream up with unauthenticated connections. We could mitigate that by forcefully disconnecting unauthenticated connections after a pre-defined timeout.
yasserf added a commit that referenced this issue Jul 27, 2016
@yasserf
Fixes #226 terminate-unauthenticated-connections
800def6
@yasserf yasserf self-assigned this Jul 27, 2016
@coveralls coveralls mentioned this issue Jul 27, 2016
Merged
@yasserf yasserf mentioned this issue Jul 27, 2016
Closed
yasserf added a commit that referenced this issue Jul 27, 2016
@yasserf
Fixes #226 terminate-unauthenticated-connections
329a1a7
timaschew added a commit that referenced this issue Jul 28, 2016
@timaschew
Merge branch 'master' into feature/#226-terminate-unauthenticated-con…
dfe4c0a 
…nections

Conflicts:
  CHANGELOG.md
  src/message/connection-endpoint.js
yasserf added a commit that referenced this issue Jul 28, 2016
@yasserf
Fixes #226 terminate-unauthenticated-connections
d57b9de
yasserf added a commit that referenced this issue Jul 28, 2016
@yasserf
Fixes #226 terminate-unauthenticated-connections
945848e
yasserf added a commit that referenced this issue Jul 28, 2016
@yasserf
Fixes #226 terminate-unauthenticated-connections
2cd6e3d
yasserf added a commit that referenced this issue Jul 28, 2016
@yasserf
Merge pull request #309 from deepstreamIO/feature/#226-terminate-unau…
c3cb842 
…thenticated-connections

Feature/#226 terminate unauthenticated connections
jaime-ez pushed a commit to jaime-ez/deepstream.io that referenced this issue Feb 20, 2024
@yasserf
deepstreamIO#203 listen functionality (deepstreamIO#226)
591f0ca 
* provide accept and reject as property of the third argument in the listen callback

* add link to deprecated issue

* fix some listening issues
- unlisten and listen
- ignore pattern removed after unlistening
- ignore has provider after discarding

* Adding new-e2e gherkin tests to build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yasserf yasserf

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WolframHempel @yasserf