Adding record version and data to VERSION_EXISTS error #1 #137
Conversation
| * | ||
| * @public | ||
| */ | ||
| RecordTransition.prototype.sendVersionExists = function( socketWrapper, version ) { |
There was a problem hiding this comment.
I'm a bit confused: How do we know the record's version before it has been loaded?
There was a problem hiding this comment.
This was based on the previous logic, which is that the last version in the steps ( updates added ) is assumed to be the records current version. I'm guessing this was to assume a positive path ( which is usually correct ).
yasserf
force-pushed
the
feature/#1versionconflicts
branch
from
ad1a1f8
to
3e938bf
Compare
| recordHandler.handle( clientB, { | ||
| raw: msg( 'R|U|existingRecord|7|{"name":"Kowalski"}' ), | ||
| topic: 'R', | ||
| action: 'U', | ||
| data: [ 'existingRecord', 7, '{"name":"Kowalski"}' ] | ||
| }); | ||
|
|
||
| setTimeout(function(){ | ||
| expect( clientA.socket.lastSendMessage ).toBeNull(); | ||
| /** |
There was a problem hiding this comment.
@WolframHempel Be good to look at this behaviour / tests
| @@ -75,11 +75,12 @@ describe( 'records are requested from cache and storage sequentually', function( | |||
| expect( options.storage.lastRequestedKey ).toBe( 'doesNotExist' ); | |||
| }); | |||
|
|
|||
| it( 'fails gracefully if an error occured out of order', function( done ){ | |||
| //TODO: yasserf: I don't get this test | |||
There was a problem hiding this comment.
it destroys the record request in between getting data from the cache and from the storage - which is not supposed to happen...but just in case
There was a problem hiding this comment.
I meant more that done is called in the record request and and after 20 milliseconds, which means it can exit successfully without any expectations run
# Conflicts: # src/record/record-transition.js
yasserf
force-pushed
the
feature/#1versionconflicts
branch
from
9f6e92e
to
8c41841
Compare
No description provided.