Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/stricter valve checks #486

Merged
merged 5 commits into from
Dec 11, 2016
Merged

Conversation

yasserf
Copy link
Contributor

@yasserf yasserf commented Dec 11, 2016

No description provided.

@yasserf yasserf merged commit 1809377 into master Dec 11, 2016
@yasserf yasserf deleted the enhancement/stricter-valve-checks branch December 11, 2016 22:03
@Iiridayn
Copy link
Contributor

Iiridayn commented Dec 12, 2016

Continuing on from #462, I missed another fun way to call a function:

var foo = { '/foo/': console.log }; foo[/foo/]('test');
Edit: or ({ '/foo/': console.log })[/foo/]('test') without variables :S

Edit:

FUNCTION_REGEXP = /([\w]+(?:['"`/]\])?)\s*\(/g

could work, but it feels too much like blacklisting/chasing holes - and still no obvious solution for the `` case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants