message-processor: Optimized + Ensure message ordering #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should have minimal performance impact with some extra memory overhead. Might even be a bit faster since it avoids array, bind and closure allocations. |
ronag
changed the title
…s maintained through permissions-handler.
Closed
|
@yasserf: We've merged this into our fork without problems so far. |
|
This makes alot of sense, raised #610 Looks like a few new things need to be ported (mainly ignoring non text messages). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several edge cases where messages going through the permission handler can be re-ordered... e.g. a
UNSUBSCRIBEcould be handled beforeREADeven though the client sentREADfirst. Same problem in other cases such asUPDATEandPATCH.Message ordering for a specific client should be maintained.