subscription registry fixes and improvements #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasserf
reviewed
Aug 7, 2017
src/utils/subscription-registry.js
Outdated
|
|
||
| const names = this._names.get(socket) || new Set() | ||
| if (names.size === 0) { | ||
| this._names.set(socket, names) | ||
| socket.once('close', this._onSocketClose) |
There was a problem hiding this comment.
this should be once per socket and not subscription
There was a problem hiding this comment.
@yasserf: It is once per socket. _names gives the set of all subscription names for a specific socket.
|
@yasserf: Any feedback on this? Would be curious to see some performance numbers from your benchmark suite. |
|
Will be looking to get those public soon, generally looks great, thank you! |
|
Not sure why the last commit causes failure. Would appreciate some help debugging that. |
yasserf
reviewed
Aug 12, 2017
src/utils/subscription-registry.js
Outdated
|
|
||
| if (this._subscriptionListener) { | ||
| this._subscriptionListener.onSubscriptionRemoved( | ||
| subscription.ame, |
|
could it be because https://github.com/deepstreamIO/deepstream.io/blob/master/src/record/record-handler.js#L658 and u removed the silent flag for unsubscribing? |
|
Sorry for making this take so long, code looks awesome! Hoping to get results on it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the general idea here is to reduce the number of allocations and lookups and improve iteration performance.