Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for perMessageDeflate to be passed to uWS #786

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

daviderenger
Copy link
Contributor

No description provided.

@Kashee-R Kashee-R added the ready label Aug 15, 2017
@yasserf
Copy link
Contributor

yasserf commented Aug 16, 2017

Hey, thanks for raising. What benefit does this provide exactly?

@daviderenger
Copy link
Contributor Author

daviderenger commented Aug 16, 2017

Hi, adding this flag allows perMessageDeflate to be negotiated with uWS and the messages will be compressed. Currently uWS is not compressing messages (I think) but it probably will in the future but the messages that are going to uWS will be compressed if they are large enough by the browser or ws on node.

I don't know if it is very useful right now and probably not for everyone but adding the option enables the feature to be tested by end users. There might be implementations of deepstream where clients sends really big messages and compressing them would be very beneficial.

Request:
....
Sec-WebSocket-Extensions:permessage-deflate; client_max_window_bits
....

Response:
...
Sec-WebSocket-Extensions:permessage-deflate; client_no_context_takeover
...

@yasserf
Copy link
Contributor

yasserf commented Aug 17, 2017

Cool, makes sense!

You okay signing our CLA?

https://deepstream.typeform.com/to/PwwNd5

@yasserf yasserf merged commit 76040dd into deepstreamIO:master Aug 17, 2017
@yasserf yasserf removed the ready label Aug 17, 2017
@yasserf
Copy link
Contributor

yasserf commented Aug 17, 2017

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants