-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Msm submodels #39
Merged
Merged
Msm submodels #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nectivity_threshold
Closed
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=========================================
- Coverage 83.97% 83.67% -0.3%
=========================================
Files 69 68 -1
Lines 4704 4620 -84
=========================================
- Hits 3950 3866 -84
Misses 754 754
Continue to review full report at Codecov.
|
thempel
reviewed
Jan 22, 2020
thempel
reviewed
Jan 22, 2020
thempel
reviewed
Jan 22, 2020
thempel
reviewed
Jan 22, 2020
thempel
reviewed
Jan 22, 2020
thempel
reviewed
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored MSMs so that the count model can create submodels, there is no more active set and no pre-selection of the largest connected set.
A consequence of this is that the ML-MSM estimator takes either an estimated count model (ie with dtraj statistics) or a count matrix for estimation.
Count models require only a count matrix to be constructed and MSMs only require a transition matrix to be constructed.
This PR is currently failing and WIP because of the lack of a consistent implementation in the HMSM case.