Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pools) create new file for pools #113

Merged
merged 7 commits into from
Jun 17, 2024

Conversation

nabaelie
Copy link
Contributor

Create a pools processes file to explain the business processes of pools

@nabaelie nabaelie closed this Jun 17, 2024
@nabaelie nabaelie reopened this Jun 17, 2024
@@ -0,0 +1,26 @@
---
title: Pool Lending Process
sidebar_position: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabaelie sidebar_position should be unique for each file , consider changing to

sidebar_position: 2

@@ -0,0 +1,20 @@
---
title: Pool Liquidation Process
sidebar_position: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sidebar_position: 3 ?

Copy link
Contributor

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit d9a05c1 into main Jun 17, 2024
1 check passed
@xavier506 xavier506 deleted the docs(pools)-creates-new-file-in-pools-documentation branch June 17, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants