fix useradd checks #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARGV wasn't processed correctly by GetOptions, switched to GetOptionsFromArray :config gnu_getopts sets ignore_case which did would match the -d (homedir) option to -D (default)
|
Many, many thanks for this. You sir just saved me quite a few hours of crawling through the code. The project is currently missing a lot of maintenance and this patch means that I can focus on other parts which need fixing. PS: I've hooked rpmgrill now into Travis CI. Once that's in I'll rebase and merge your request. Again, thanks a lot!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARGV wasn't processed correctly by GetOptions, switched to GetOptionsFromArray
:config gnu_getopts sets ignore_case which did would match the -d (homedir) option to -D (default)
This fixes false UseraddNoHomedir and UseraddNoShell as reported here: https://taskotron.fedoraproject.org/artifacts/all/c1ed11d4-a60e-11e6-be4f-525400120b80/task_output/rpmgrill.json