Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Please add List<ItemStack> analysis in FluidCraftRecipe #89

Closed
Prunoideae opened this issue Mar 25, 2019 · 10 comments
Closed

Comments

@Prunoideae
Copy link

Yep, I'm still working on the development of integration between HAC and CT, Mills and Spinning Machine was fully supported but the problem is that I can't pass a list of items to the constructor of FluidCraftRecipe, which caused a result that using OreDictionary while specifying the amount of items will be consumed.
TIM截图20190325180832
Using strings can of course be a solution, but the amount of items will be consumed is impossible to specify.

Just like what the crusher can do:
image

Only a suggestion :-P

@Prunoideae
Copy link
Author

Here's my code process:
TIM截图20190325181411
I created a private list of list, adding every input Ingredient to it by using Primer.addInput, and the code will retrieve every item of the dictionary and set amount of it, then pass it to the construction of FluidCraftRecipe in Primer.ignite():
image
And that's where the problem occurred.
image

@Prunoideae
Copy link
Author

well, using inputs.toArray() doesn't help anything at all, I though the problem is that List itself was recognized as only one variable, but changing this doesn't help.

@Prunoideae
Copy link
Author

TIM截图20190325182850
TIM截图20190325182840
Using string to represent oredictionary is usable, but not good enough because the item count is always limited to 1......

@Prunoideae
Copy link
Author

well, every machine except spinning machine only take one item each operation... that's a problem needs to be solved also :-(

@defeatedcrow
Copy link
Owner

Liquid Crafting devices (the pot and chemical reactor) consume only one material per slot. Those machines, (like vanilla stove,) can not change the consumption by recipe registration because the consumption of the item is specified as 1 as a constraint on the implementation of TileEntity.

As these machines have multiple input slots, if the recipe has consumption of 2 or more, often "fractional items" will remain in the slots, which hinders the automatic operation of the machine. These were tested and deleted features because they were stressful to me in test play. There are no plans to change specifications in the future.

@defeatedcrow
Copy link
Owner

If you would like to propose another machine and recipe, please make another issue. They differ in the cause and topic of the issue.

@Prunoideae
Copy link
Author

OK, if it's a preserved feature, there's no reason for me to change it.

@defeatedcrow
Copy link
Owner

The problem is distributed.
What is your request?

My answer is

  • There are no plans to change the for "liquid recipe" consume amount.
  • About other machines that have only one input slot can be considered. (It takes time because they require redesign of the machine)

The issue was aborted with insufficient conversation. Are you really ok with this?

@defeatedcrow defeatedcrow reopened this Mar 25, 2019
@Prunoideae
Copy link
Author

Prunoideae commented Mar 25, 2019

Well, if other machines are ok, then I think it's good to make things more flexible.
Though my first purpose was just to make liquid recipe consume specific amount, but that's not a big deal.

@defeatedcrow
Copy link
Owner

OK, I'll consider it about other machines.
I'm sorry about the liquid recipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants