Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitForDeployment in journey test does not wait for watcher deployment #481

Closed
cmwylie19 opened this issue Jan 12, 2024 · 0 comments · Fixed by #482
Closed

waitForDeployment in journey test does not wait for watcher deployment #481

cmwylie19 opened this issue Jan 12, 2024 · 0 comments · Fixed by #482
Assignees

Comments

@cmwylie19
Copy link
Collaborator

Environment

Steps to reproduce

In the pepr-deploy journey test the watcher deployment is not considered. This is a nit as the test does ensure data is written to the store from a watch action

Expected result

Actual Result

Visual Proof (screenshots, videos, text, etc)

Severity/Priority

Additional Context

Add any other context or screenshots about the technical debt here.

@cmwylie19 cmwylie19 self-assigned this Jan 12, 2024
btlghrants added a commit that referenced this issue Jan 12, 2024
## Description

Just a small fix to be thorough in journey test and wait for both
deployments

## Related Issue

Fixes #481 
<!-- or -->
Relates to #

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/pepr/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Co-authored-by: Barrett <81570928+btlghrants@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant