Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementation for custom labels #571

Merged
merged 4 commits into from
Feb 16, 2024
Merged

feat: implementation for custom labels #571

merged 4 commits into from
Feb 16, 2024

Conversation

cmwylie19
Copy link
Collaborator

@cmwylie19 cmwylie19 commented Feb 13, 2024

Description

Through code allows the users to create customLabels for Kubernetes objects. The customLabels object is now placed in the module class definition and can be extended as more Kubernetes objects need custom labels

Related Issue

Fixes #569

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmwylie19 cmwylie19 merged commit 6b1ef64 into main Feb 16, 2024
11 checks passed
@cmwylie19 cmwylie19 deleted the 569 branch February 16, 2024 18:35
@cmwylie19 cmwylie19 changed the title chore: implementation for custom labels feat: implementation for custom labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

chore: ability to set custom labels in pepr-system ns
2 participants