Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no zeroeth uid #573

Merged
merged 5 commits into from
Feb 14, 2024
Merged

fix: no zeroeth uid #573

merged 5 commits into from
Feb 14, 2024

Conversation

btlghrants
Copy link
Collaborator

@btlghrants btlghrants commented Feb 13, 2024

Description

This PR:

  • Adds a guard clause to the admission response gen code (invoked after all Pepr-known validations have run) to cover the case where all validations were legitimate "skips" (i.e. not stuff in Pepr-controlled namespaces) -- it adds a special "no validations needed"-type admission response such that we no longer try to access '.uid' property of a [0]-th element that doesn't exist.

In addition, it:

  1. Adds "--yes" flag to pepr-upgrade.test.ts npx invocation to prevent wait for user input in the case where it has to ask for permission to npx-install ts-node (like when a dev (me!) has not npx ts-node-ed before).

Related Issue

Fixes #572

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

socket-security bot commented Feb 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

@btlghrants btlghrants changed the title No zeroeth uid fix: no zeroeth uid Feb 13, 2024
@cmwylie19
Copy link
Collaborator

Makes sense, we were missing that clause. Good catch and PR!

@cmwylie19 cmwylie19 merged commit 17afbd2 into main Feb 14, 2024
11 checks passed
@cmwylie19 cmwylie19 deleted the no-zeroeth-uid branch February 14, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Pepr controller logs showing 'Cannot read properties of undefined (reading 'uid')'
2 participants