Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: custom label docs #589

Merged
merged 3 commits into from
Feb 20, 2024
Merged

chore: custom label docs #589

merged 3 commits into from
Feb 20, 2024

Conversation

cmwylie19
Copy link
Collaborator

Description

Include documentation around adding custom labels to Pepr generated manifests.

Related Issue

Fixes #586

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Copy link
Collaborator

@schaeferka schaeferka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the custom labels section up? Maybe put it after "My Pepr version is not latest"? And maybe change "My Pepr version is not latest" to "My Pepr version is not the latest?"

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cmwylie19 cmwylie19 merged commit 9130cff into main Feb 20, 2024
11 checks passed
@cmwylie19 cmwylie19 deleted the 586 branch February 20, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Update docs to show custom labels
3 participants