Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ns bug on watch and queue #617

Merged
merged 12 commits into from
Mar 8, 2024
Merged

chore: fix ns bug on watch and queue #617

merged 12 commits into from
Mar 8, 2024

Conversation

cmwylie19
Copy link
Collaborator

@cmwylie19 cmwylie19 commented Mar 4, 2024

Description

Fixes bug on watch processor around firing callbacks for bindings where object namespace is different than binding namespace filter.

const { When } = HelloPepr;
let watchCount = 0;
When(a.Pod)
.IsCreatedOrUpdated()
.InNamespace("pepr-demo")
.Watch(() => {
  Log.info(`watchCount is ${watchCount++}.`)
})

Related Issue

Fixes #610

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btlghrants btlghrants merged commit 3d8db0e into main Mar 8, 2024
11 checks passed
@btlghrants btlghrants deleted the 610 branch March 8, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Watch filter does not respect capability namespaces
2 participants