chore: filter bug

[cmwylie19]

Description

In Binding Filters, labels do not have to have values, they only have to have keys. In the event that there is not value, there is an implication that the value is "" (empty string).

This scenario was overlooked in the checkOverlap function which checks if the binding's filters/annotations have overlap with the objects.

This was causing an error in UDS-Core as a pod was being ignored that contained the same key as the binding but a different value.

export function checkOverlap(record1: Record<string, string>, record2: Record<string, string>) {
  if (Object.keys(record1).length === 0) {
    return true;
  }
  for (const key in record1) {
    if (
      Object.prototype.hasOwnProperty.call(record1, key) &&
      Object.prototype.hasOwnProperty.call(record2, key) &&
      record1[key] === record2[key] // VALUES MUST BE THE SAME
    ) {
      return true;
    }
  }
  return false;
}

For Example:

When(a.ConfigMap)
  .IsCreated()
  .WithLabel("chuck-norris")
  .Mutate(async change => {
    // Try/catch is not needed as a response object will always be returned
    const response = await fetch<TheChuckNorrisJoke>(
      "https://api.chucknorris.io/jokes/random?category=dev",
    );

Related Issue

Fixes #

Relates to #

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Other (security config, docs update, etc)

Checklist before merging

• Test, docs, adr added or updated as needed
• Contributor Guide Steps followed

[cmwylie19]

Need to accommodate for AND, when both labels should match. This functionality currently does not

When(a.Pod)
  .IsUpdated()
  .WithLabel("batch.kubernetes.io/job-name")
  .WithLabel("service.istio.io/canonical-name")

[btlghrants]

Seems pretty legit.

[btlghrants]

K!