fix: cacert fix and cleanup #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnicornChance
requested review from
rjferguson21,
mjnagel,
MxNxPx,
TristanHoladay,
justin-o12 and
adam-defenseunicorns
mjnagel
reviewed
Mar 22, 2024
Comment on lines
+37
to
+38
| yq eval-all --inplace 'select(fileIndex == 0) * select(fileIndex == 1)' src/istio/values/config-tenant.yaml tls_cacert.yaml | ||
| yq eval-all --inplace 'select(fileIndex == 0) * select(fileIndex == 1)' src/istio/values/config-admin.yaml tls_cacert.yaml |
There was a problem hiding this comment.
Is it correct that this shouldn't be merged until an updated identity-config image/task is actually producing tls_cacert.yaml?
There was a problem hiding this comment.
@mjnagel correct. This task is not actively being used anywhere so we wouldnt see anything break. The identity change is captured in my registration integration test branch which is still wip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was some extra fields accidentally brought into the cacert for keycloak istio gateways, removed those.
Task to copy cacert generated in identity-config into gateways doesn't work on non-mac users machines. Fix for that task and a change will be added to the identity side as well in this branch.
Type of change
Checklist before merging