Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unevenly sized multi-part packages #2313

Closed
Racer159 opened this issue Feb 19, 2024 · 0 comments · Fixed by #2314
Closed

Unevenly sized multi-part packages #2313

Racer159 opened this issue Feb 19, 2024 · 0 comments · Fixed by #2314
Labels
bug 🐞 Something isn't working

Comments

@Racer159
Copy link
Contributor

Environment

Device and OS: System76 darp8
App version: v0.32.3
Kubernetes distro being used: n/a
Other: n/a

Steps to reproduce

  1. Create a package with --max-package-size set smaller than the resulting package

Expected result

Even chunks of a package are created
image

Actual Result

Varying chunks are created
image

Severity/Priority

Medium

Additional Context

This effectively breaks this feature on v0.32.3 - workaround for now is to downgrade to v0.32.2 for those who need this
@Racer159 Racer159 added the bug 🐞 Something isn't working label Feb 19, 2024
@Racer159 Racer159 mentioned this issue Feb 19, 2024
Merged
5 tasks
Racer159 added a commit that referenced this issue Feb 20, 2024
@Racer159 @AustinAbro321 @lucasrod16
fix: multi-part tarballs being mismatched sizes (#2314)
07541a6 
## Description

This fixes multipart tarballs being different sizes with
`--max-package-size`

## Related Issue

Fixes #2313

## Type of change

- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Co-authored-by: Lucas Rodriguez <lucas.rodriguez9616@gmail.com>
Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
@Noxsios Noxsios mentioned this issue Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
No open projects
Zarf Project Board
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: multi-part tarballs being mismatched sizes defenseunicorns/zarf
1 participant
@Racer159