Fail when package architecture doesn't match cluster architecture #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add e2e test for verify this check works
✅ Deploy Preview for zarf-docs canceled.
|
Update test to require the specific error string to be returned
Use ErrorAs function in test to check for specific error message returned
|
This PR is ready for review whenever somebody gets the chance to take a look. |
Racer159
requested changes
Mar 30, 2023
This reverts commit 1768191.
Wrap arch command substitution in double quotes Add proper error message in echo statement Add description to zarf actions
Racer159
requested changes
May 8, 2023
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Use switch statement instead of if statement and return the opposite arch string Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Noxsios
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fail
zarf initandzarf package deploywhen package architecture doesn't match cluster architectureDeployment scenarios that this PR covers:
If
zarf initis ran in appliance mode(deploying k3s), verify that the package architecture matches the machine that zarf is attempting to initialize with a k3s clusterIf
zarf initorzarf package deployis ran, verify that the package architecture matches the target cluster architectureRelated Issue
Fixes #1491
Relates to #955
Type of change
Checklist before merging