Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially require 1.54.0 or greater of Big Bang now #1559

Merged
merged 6 commits into from
Apr 7, 2023

Conversation

dgershman
Copy link
Contributor

Description

This makes the requirement for the bigbang component officially 1.54.0 or greater.

Related Issue

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@dgershman dgershman changed the title require 1.54.0 or greater of Big Bang now Officially require 1.54.0 or greater of Big Bang now Apr 5, 2023
@netlify
Copy link

netlify bot commented Apr 5, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 5b81424
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/642f51187d9b9d000864c257

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgershman
Copy link
Contributor Author

I found an issue with this, when attempting to test against BB 1.57.0-rc.0 the isValidVersion function fails. Testing a change out to support BB release candidate tags.

@dgershman
Copy link
Contributor Author

I found an issue with this, when attempting to test against BB 1.57.0-rc.0 the isValidVersion function fails. Testing a change out to support BB release candidate tags.

Changes pushed. I'm using a library already referenced by another package to parse the semantic version (based on Semver v2). I also added some unit tests.

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small suggestions

src/extensions/bigbang/bigbang.go Outdated Show resolved Hide resolved
src/extensions/bigbang/bigbang.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Racer159 Racer159 merged commit 8bf4af1 into zarf-dev:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants