Remove unnecessary logging package and set log level in root #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could just add a message acknowledging when the user changes the log level and test for that. It would be better UX anyway. |
jeff-mccoy
previously approved these changes
Nov 4, 2021
|
/test all |
jeff-mccoy
previously approved these changes
Nov 5, 2021
|
@YrrepNoj note the merge conflict currently |
YrrepNoj
force-pushed
the
bug/fix-log-levels
branch
from
d5067ba
to
65bdca3
Compare
|
/test all |
jeff-mccoy
approved these changes
Nov 5, 2021
jeff-mccoy
pushed a commit
that referenced
this pull request
Feb 8, 2022
Signed-off-by: Jeff McCoy <code@jeffm.us>
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
Signed-off-by: Jeff McCoy <code@jeffm.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the logging package that I meant to remove when we realized we didn't need to wrap the Logrus object.
@RothAndrew do you have any ideas on how we can create a test to verify the CLI was able to interpret and set the correct logging level?