-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding renovate support for bigbang #1585
adding renovate support for bigbang #1585
Conversation
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! (and apologies it took a bit longer to get to). I think that this will also need something like the following in the regexManagers
section of our renovate.json
as well:
"regexManagers": [
{
"fileMatch": [
"(^|/)zarf.yaml$"
],
"matchStringsStrategy": "recursive",
"matchStrings": [
"# renovate: datasource=(?<datasource>.*?) depName=(?<depName>.*?)( versioning=(?<versioning>.*?))?( registryUrl=(?<registryUrl>.*?))?\\s.*?version: (?<currentValue>.*)\\s"
],
"versioningTemplate": "{{#if versioning}}{{{versioning}}}{{else}}semver{{/if}}"
}
...
]
At least per: https://docs.renovatebot.com/modules/datasource/gitlab-releases/
You can also test this out here: https://regex101.com/r/w3iKgK/1 (note that renovate requires that you escape backslashes so the \s
s on regex101 become \\s
in the renovate.json - you can also compare against the existing regex manager we have for helm charts as well.
ae64d70
to
81be937
Compare
Thanks, you are right! Updated.
From: Wayne Starr ***@***.***>
Date: Wednesday, April 12, 2023 at 8:06 PM
To: defenseunicorns/zarf ***@***.***>
Cc: Danny Gershman ***@***.***>, Author ***@***.***>
Subject: Re: [defenseunicorns/zarf] adding renovate support for bigbang (PR #1585)
@Racer159 requested changes on this pull request.
Thanks for the PR! (and apologies it took a bit longer to get to). I think that this will also need something like the following in the regexManagers section of our renovate.json as well:
"regexManagers": [
{
"fileMatch": [
"(^|/)zarf.yaml$"
],
"matchStringsStrategy": "recursive",
"matchStrings": [
"# renovate: datasource=(?<datasource>.*?) depName=(?<depName>.*?)( versioning=(?<versioning>.*?))?( registryUrl=(?<registryUrl>.*?))?\\s.*?version: (?<currentValue>.*)\\s"
],
"versioningTemplate": "{{#if versioning}}{{{versioning}}}{{else}}semver{{/if}}"
}
...
]
At least per: https://docs.renovatebot.com/modules/datasource/gitlab-releases/
You can also test this out here: https://regex101.com/r/w3iKgK/1 (note that renovate requires that you escape backslashes so the \ss on regex101 become \\s in the renovate.json - you can also compare against the existing regex manager we have for helm charts as well.
—
Reply to this email directly, view it on GitHub<#1585 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAOD3O57JQDGFNOM34GBN7TXA47QRANCNFSM6AAAAAAWZVJAVM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
058d9d7
to
7993f57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm but it looks like your base branch is out of date - not sure if you can enable it but there is a setting to allow changes from maintainers if you'd like - https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
This documentation is pretty bad. I don't see an obvious way to enable this. |
Hmm yeah I also think you have to be the "owner" of the repo from my read through it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I think this is a bug, it may work for personal repos, but not orgs https://github.com/orgs/community/discussions/5634. |
It doesn't seem like this is working :( |
…1836) ## Description By [default](https://github.com/renovatebot/renovate/blob/e34f138a08dfcbb60ebc9f0c2a20cc8f09f95fde/lib/config/presets/internal/default.ts#L298) renovate ignores the `examples` path. After [implementing checks against Big Bang versions in Repo1](#1585), I've noticed that renovate was not able to detect any issues. I did some local debugging and discovered the issue. This MR adds all the defaults, minus the examples directory. Testing locally: ```shell LOG_LEVEL=debug renovate --token <token> --platform=local --dry-run ``` ## Related Issue #1585 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Description
Adding renovate support for Big Bang Releases, inline. If this is not acceptable will go with the JSON method.
Related Issue
Relates to #1569
Type of change
Checklist before merging