Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding renovate support for bigbang #1585

Merged

Conversation

dgershman
Copy link
Collaborator

Description

Adding renovate support for Big Bang Releases, inline. If this is not acceptable will go with the JSON method.

Related Issue

Relates to #1569

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Apr 11, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 1edbaa7
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6440a1d6aeab2c0008b29717
😎 Deploy Preview https://deploy-preview-1585--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! (and apologies it took a bit longer to get to). I think that this will also need something like the following in the regexManagers section of our renovate.json as well:

  "regexManagers": [
    {
      "fileMatch": [
        "(^|/)zarf.yaml$"
      ],
      "matchStringsStrategy": "recursive",
      "matchStrings": [
        "# renovate: datasource=(?<datasource>.*?) depName=(?<depName>.*?)( versioning=(?<versioning>.*?))?( registryUrl=(?<registryUrl>.*?))?\\s.*?version: (?<currentValue>.*)\\s"
      ],
      "versioningTemplate": "{{#if versioning}}{{{versioning}}}{{else}}semver{{/if}}"
    }
    ...
  ]

At least per: https://docs.renovatebot.com/modules/datasource/gitlab-releases/

You can also test this out here: https://regex101.com/r/w3iKgK/1 (note that renovate requires that you escape backslashes so the \ss on regex101 become \\s in the renovate.json - you can also compare against the existing regex manager we have for helm charts as well.

@dgershman dgershman force-pushed the renovate-support-for-bigbang branch from ae64d70 to 81be937 Compare April 13, 2023 00:11
@dgershman
Copy link
Collaborator Author

dgershman commented Apr 13, 2023 via email

@dgershman dgershman force-pushed the renovate-support-for-bigbang branch from 058d9d7 to 7993f57 Compare April 14, 2023 02:57
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm but it looks like your base branch is out of date - not sure if you can enable it but there is a setting to allow changes from maintainers if you'd like - https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@dgershman
Copy link
Collaborator Author

This lgtm but it looks like your base branch is out of date - not sure if you can enable it but there is a setting to allow changes from maintainers if you'd like - https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

This documentation is pretty bad. I don't see an obvious way to enable this.

@Racer159
Copy link
Contributor

Hmm yeah I also think you have to be the "owner" of the repo from my read through it...

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dgershman
Copy link
Collaborator Author

Hmm yeah I also think you have to be the "owner" of the repo from my read through it...

I think this is a bug, it may work for personal repos, but not orgs https://github.com/orgs/community/discussions/5634.

@Racer159 Racer159 merged commit 2fb5f1c into defenseunicorns:main Apr 21, 2023
20 checks passed
@dgershman
Copy link
Collaborator Author

It doesn't seem like this is working :(

Racer159 added a commit that referenced this pull request Jun 26, 2023
…1836)

## Description

By
[default](https://github.com/renovatebot/renovate/blob/e34f138a08dfcbb60ebc9f0c2a20cc8f09f95fde/lib/config/presets/internal/default.ts#L298)
renovate ignores the `examples` path. After [implementing checks against
Big Bang versions in
Repo1](#1585), I've noticed
that renovate was not able to detect any issues. I did some local
debugging and discovered the issue. This MR adds all the defaults, minus
the examples directory.

Testing locally:

```shell
LOG_LEVEL=debug renovate --token <token> --platform=local --dry-run
```

## Related Issue

#1585

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants