Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add permisssions to nightly workflow to request the OIDC JWT token #1627

Merged
merged 28 commits into from
Apr 24, 2023

Conversation

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 7e3c47d
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6446823319ccbb0008d0ecd0
😎 Deploy Preview https://deploy-preview-1627--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Racer159
Racer159 previously approved these changes Apr 19, 2023
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good just logging q's

.github/workflows/nightly-ecr.yml Outdated Show resolved Hide resolved
.github/workflows/nightly-eks.yml Show resolved Hide resolved
@YrrepNoj YrrepNoj force-pushed the update-nightly-workflow-permissions branch from 8bdd318 to cbb1bbf Compare April 21, 2023 20:12
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit c316e3b into main Apr 24, 2023
21 checks passed
@Racer159 Racer159 deleted the update-nightly-workflow-permissions branch April 24, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants