Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability for zarf to template folders of files #1696

Merged
merged 30 commits into from
May 19, 2023
Merged

Add the ability for zarf to template folders of files #1696

merged 30 commits into from
May 19, 2023

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented May 11, 2023 •
edited

Description

This allows Zarf to template files in a folder in addition to individual files.

Related Issue

Fixes #1617
Fixes #1698
Fixes #1697
Fixes #1525
Fixes #1499

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented May 11, 2023 •
edited

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit aa270a6
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6466a23b19e52400087c5c6e

@Racer159 Racer159 added needs-docs PR Label - Docs required to merge needs-tests PR Label - Tests required to merge labels May 11, 2023
@Racer159 Racer159 removed the needs-tests PR Label - Tests required to merge label May 12, 2023
@Racer159 Racer159 removed the needs-docs PR Label - Docs required to merge label May 12, 2023
Noxsios
Noxsios previously requested changes May 15, 2023
View reviewed changes
src/pkg/message/message.go Outdated Show resolved Hide resolved
src/pkg/packager/create.go Outdated Show resolved Hide resolved
src/pkg/packager/deploy.go Outdated Show resolved Hide resolved
src/pkg/utils/io.go Outdated Show resolved Hide resolved
src/test/e2e/04_create_templating_test.go Outdated Show resolved Hide resolved
src/test/e2e/04_create_templating_test.go Outdated Show resolved Hide resolved
src/test/e2e/23_data_injection_test.go Outdated Show resolved Hide resolved
src/test/e2e/23_data_injection_test.go Outdated Show resolved Hide resolved
YrrepNoj
YrrepNoj previously approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; minor nit but not something I'd block the PR over

src/pkg/utils/io.go Outdated Show resolved Hide resolved
@Racer159 Racer159 dismissed Noxsios’s stale review May 19, 2023 17:21

Messaged separately on slack that Noxios is good with this PR as is

@Racer159 Racer159 merged commit adee149 into main May 19, 2023
21 checks passed
@Racer159 Racer159 deleted the 1617-zarf-does-not-template-files-folder branch May 19, 2023 17:21
@timblaktu timblaktu mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YrrepNoj YrrepNoj YrrepNoj approved these changes

@Noxsios Noxsios Noxsios left review comments

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@mike-winberry mike-winberry Awaiting requested review from mike-winberry

@Madeline-UX Madeline-UX Awaiting requested review from Madeline-UX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Racer159 @YrrepNoj @Noxsios