Capitalize WordPress in docs correctly #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottok
requested review from
mike-winberry,
Racer159,
Noxsios,
jeff-mccoy,
YrrepNoj and
Madeline-UX
as code owners
✅ Deploy Preview for zarf-docs canceled.
|
Racer159
reviewed
May 12, 2023
There was a problem hiding this comment.
Thanks for the catch @ottok !
The changes look good to me though your commit will need to be signed to merge - see num 3 under Developer Workflow https://docs.zarf.dev/docs/contribute-to-zarf/contributor-guide#developer-workflow
To make the docs more appealing to WordPress users spell the software name correctly with a capital P. See e.g. https://developer.wordpress.org/reference/functions/capital_p_dangit/ - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed ---------
|
Sorry forgot - commit signed now and I ran |
YrrepNoj
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make the docs more appealing to WordPress users spell the software name correctly with a capital P.
See e.g. https://developer.wordpress.org/reference/functions/capital_p_dangit/
Type of change
Checklist before merging