-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle OCI Imported Components When Creating a Differential Package #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Racer159
requested changes
May 17, 2023
YrrepNoj
force-pushed
the
oci-differential
branch
from
May 17, 2023 17:18
7ac1110
to
8e72560
Compare
Racer159
requested review from
mike-winberry,
Madeline-UX and
a team
as code owners
May 17, 2023 19:58
✅ Deploy Preview for zarf-docs canceled.
|
YrrepNoj
force-pushed
the
oci-differential
branch
from
May 17, 2023 21:12
5cbd779
to
ad44ca6
Compare
YrrepNoj
force-pushed
the
oci-differential
branch
from
May 18, 2023 15:58
ad44ca6
to
cf98445
Compare
Racer159
requested changes
May 18, 2023
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Racer159
approved these changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a differential package, Zarf now considers OCI imported components as versioned assets. Since the OCI imported components are versioned assets, if Zarf is performing a differential build and the version of the OCI component we're important hasn't changed, Zarf will no longer include that OCI-Imported Component in the finalized differential Package.
Closes #1426