Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle OCI Imported Components When Creating a Differential Package #1714

Merged
merged 21 commits into from
May 19, 2023

Conversation

YrrepNoj
Copy link
Member

@YrrepNoj YrrepNoj commented May 16, 2023

When creating a differential package, Zarf now considers OCI imported components as versioned assets. Since the OCI imported components are versioned assets, if Zarf is performing a differential build and the version of the OCI component we're important hasn't changed, Zarf will no longer include that OCI-Imported Component in the finalized differential Package.

Closes #1426

@Racer159 Racer159 marked this pull request as ready for review May 17, 2023 02:26
src/test/e2e/52_oci_compose_differential_test.go Outdated Show resolved Hide resolved
examples/podinfo-flux/zarf.yaml Outdated Show resolved Hide resolved
src/types/component.go Outdated Show resolved Hide resolved
src/pkg/packager/create.go Outdated Show resolved Hide resolved
src/test/e2e/52_oci_compose_differential_test.go Outdated Show resolved Hide resolved
src/test/e2e/52_oci_compose_differential_test.go Outdated Show resolved Hide resolved
src/types/component.go Outdated Show resolved Hide resolved
Base automatically changed from oci-package-compose to main May 17, 2023 19:58
@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 90d8f58
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6467cfe02a8e1d0008b15873

docs/3-create-a-zarf-package/1-zarf-packages.md Outdated Show resolved Hide resolved
src/pkg/packager/create.go Outdated Show resolved Hide resolved
src/pkg/packager/create.go Outdated Show resolved Hide resolved
src/pkg/packager/create.go Show resolved Hide resolved
src/test/common.go Show resolved Hide resolved
src/test/test-packages/52-oci-differential/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 enabled auto-merge (squash) May 19, 2023 19:40
@Racer159 Racer159 merged commit 73e998a into main May 19, 2023
21 checks passed
@Racer159 Racer159 deleted the oci-differential branch May 19, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differential Updates for Composable Components
2 participants