feat: add scheduling logic to zarf injector #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragingpastry
requested review from
jeff-mccoy,
YrrepNoj,
Racer159 and
Noxsios
as code owners
✅ Deploy Preview for zarf-docs canceled.
|
ragingpastry
force-pushed
the
zarf-injector-no-schedule
branch
from
108debd
to
6dc6562
Compare
Racer159
requested changes
May 18, 2023
ragingpastry
force-pushed
the
zarf-injector-no-schedule
branch
2 times, most recently
from
5c6ae3e
to
eb8de6d
Compare
Racer159
requested changes
May 18, 2023
ragingpastry
force-pushed
the
zarf-injector-no-schedule
branch
from
eb8de6d
to
2935820
Compare
Racer159
requested changes
May 18, 2023
There was a problem hiding this comment.
I can't request it as a suggestion in this PR but one tiny thing after testing locally: Can you make the spinner for gathering images notify the user of the 5 minute timeout since they may hit that if all nodes have taints (similar to how waiting for cluster connection works)?
https://github.com/defenseunicorns/zarf/blob/main/src/internal/cluster/injector.go#L44
// Get all the images from the cluster
timeout := 5 * time.Minute
spinner.Updatef("Getting the list of existing cluster images (%s timeout)", timeout.String())")
if images, err = c.Kube.GetAllImages(timeout); err != nil {https://github.com/defenseunicorns/zarf/blob/main/src/pkg/k8s/images.go#L22
func (k *K8s) GetAllImages(timeoutDuration time.Duration) (ImageNodeMap, error) {
timeout := time.After(timeoutDuration)
ragingpastry
force-pushed
the
zarf-injector-no-schedule
branch
from
2935820
to
67397b1
Compare
ragingpastry
force-pushed
the
zarf-injector-no-schedule
branch
from
67397b1
to
2e5b5c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checks to ensure that a node does not have a
NoScheduletaint before choosing that node/image for the Zarf injector podRelated Issue
Fixes #1730
Fixes #905
Type of change
Checklist before merging
Gave this a WAG. It seems to work locally, but am unsure if this is the direction you guys want to go. Let me know!