Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: differential package create with non local sources #2444

Merged
merged 4 commits into from
Apr 18, 2024
Merged

fix: differential package create with non local sources #2444

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dcdad6f
fix differential-oci
AustinAbro321 Apr 18, 2024
fbdfeac
testing
AustinAbro321 Apr 18, 2024
5e14aed
naming
AustinAbro321 Apr 18, 2024
0c46cd0
fix tests for windows
AustinAbro321 Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/pkg/packager/creator/normal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ type PackageCreator struct {

// NewPackageCreator returns a new PackageCreator.
func NewPackageCreator(createOpts types.ZarfCreateOptions, cfg *types.PackagerConfig, cwd string) *PackageCreator {
if createOpts.DifferentialPackagePath != "" && !filepath.IsAbs(createOpts.DifferentialPackagePath) {
if createOpts.DifferentialPackagePath != "" &&
!filepath.IsAbs(createOpts.DifferentialPackagePath) &&
!helpers.IsURL(createOpts.DifferentialPackagePath) {
lucasrod16 marked this conversation as resolved.
Show resolved Hide resolved
createOpts.DifferentialPackagePath = filepath.Join(cwd, createOpts.DifferentialPackagePath)
}

Expand Down