Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize trace references for debug/trace output #305

Merged
merged 2 commits into from Feb 11, 2022

Conversation

jeff-mccoy
Copy link
Member

Depending on what functions are called for debug/trace the wrong callstack offsets could occur creating a problem where the wrong debug point is listed (sometimes within a library making it difficult to understand the issue)

@jeff-mccoy jeff-mccoy marked this pull request as draft February 9, 2022 12:46
@jeff-mccoy jeff-mccoy self-assigned this Feb 9, 2022
@YrrepNoj YrrepNoj self-requested a review February 11, 2022 20:32
Copy link
Member

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeff-mccoy
Copy link
Member Author

/test all

@jeff-mccoy
Copy link
Member Author

/test all

@jeff-mccoy jeff-mccoy marked this pull request as ready for review February 11, 2022 22:39
@jeff-mccoy jeff-mccoy merged commit ad6acde into master Feb 11, 2022
@jeff-mccoy jeff-mccoy deleted the fix/trace-log-depth branch February 11, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants