-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase docker registry and git-server push fault-tolerance #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YrrepNoj
requested changes
Jul 5, 2022
YrrepNoj
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the usability of having the default connection commands using dynamic ports. Whoever came up with that had a really good idea 😉
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
* Stop adding zarf registry to local docker config * allow dynamic port binding for git/registry * fix updates to git-server test & optimize test sequence * clean connect table and zarf connect msg output * remove test time buffer now that ports are dynamic * Cleanup repo/image pushing & add retry logic * Only dump tunnel endpoint if auto-open is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes important changes to how the Zarf CLI interacts with a Docker Registry and Git Server during
zarf package create
operations. These changes were needed as some of the implementation details were related to legacy registry/git interactions from before v0.15.0:zarf connect git|logging|registry
, this prevents issues where an existing binding is still open such as in CI/CD or when I user accidentally leaves a tunnel open in another terminal or background task. This is also part of the larger strategy for the utility cluster: If you need to interact with the cluster outside of Zarf or the in-cluster use by Zarf, then an ingress should be exposed.zarf tools registry login
provided by Crane.Related Issue
Fixes #515, #580
Related to #186
Type of change
Checklist before merging
needs-tests
label)needs-docs
label)