Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase docker registry and git-server push fault-tolerance #586

Merged
merged 11 commits into from
Jul 5, 2022

Conversation

jeff-mccoy
Copy link
Member

@jeff-mccoy jeff-mccoy commented Jul 2, 2022

Description

This PR makes important changes to how the Zarf CLI interacts with a Docker Registry and Git Server during zarf package create operations. These changes were needed as some of the implementation details were related to legacy registry/git interactions from before v0.15.0:

  • BREAKING CHANGE: No longer store credentials for docker or git locally to support changes/fixes below
  • Dynamic local port binding for zarf connect git|logging|registry, this prevents issues where an existing binding is still open such as in CI/CD or when I user accidentally leaves a tunnel open in another terminal or background task. This is also part of the larger strategy for the utility cluster: If you need to interact with the cluster outside of Zarf or the in-cluster use by Zarf, then an ingress should be exposed.
  • Remove docker-cli dependency that now seems to be breaking some systems where docker isn't running (even though the code should not directly depend on docker running
  • Users that still want to use Zarf to log into a registry without docker can still use zarf tools registry login provided by Crane.

Related Issue

Fixes #515, #580
Related to #186

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • Documentation has been updated as necessary (add the needs-docs label)

@jeff-mccoy jeff-mccoy added bug 🐞 Something isn't working enhancement ✨ New feature or request k8s breaking-change 💔 labels Jul 2, 2022
@jeff-mccoy jeff-mccoy marked this pull request as ready for review July 3, 2022 06:22
@jeff-mccoy jeff-mccoy changed the title Disable docker for k3s test Increase docker registry and git-server push fault-tolerance Jul 3, 2022
jeff-mccoy added a commit that referenced this pull request Jul 4, 2022
src/internal/message/spinner.go Show resolved Hide resolved
src/internal/packager/deploy.go Show resolved Hide resolved
src/internal/k8s/tunnel.go Outdated Show resolved Hide resolved
src/test/e2e/21_logging_test.go Show resolved Hide resolved
@jeff-mccoy jeff-mccoy requested a review from YrrepNoj July 5, 2022 17:21
Copy link
Member

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the usability of having the default connection commands using dynamic ports. Whoever came up with that had a really good idea 😉

@jeff-mccoy jeff-mccoy merged commit c50f618 into master Jul 5, 2022
@jeff-mccoy jeff-mccoy deleted the fix/avoid-docker-call branch July 5, 2022 17:27
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
* Stop adding zarf registry to local docker config
* allow dynamic port binding for git/registry
* fix updates to git-server test & optimize test sequence
* clean connect table and zarf connect msg output
* remove test time buffer now that ports are dynamic
* Cleanup repo/image pushing & add retry logic
* Only dump tunnel endpoint if auto-open is disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change 💔 bug 🐞 Something isn't working enhancement ✨ New feature or request k8s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry image pushes to the Zarf Registry
2 participants