Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor syft/migrate witness -> syft direct #716

Merged
merged 8 commits into from
Sep 8, 2022
Merged

Conversation

jeff-mccoy
Copy link
Member

Adds zarf tools syft command for full access to https://github.com/anchore/syft. Also migrates from 3rd party wrapper (Wtiness) to direct Syft integration. Refactored code to prepare for adding file-based SBOM generation in addition to image-based.

@jeff-mccoy
Copy link
Member Author

Screen Shot 2022-09-07 at 3 31 16 AM

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and this worked fine. Like that we are moving to a builder pattern and just fixed a small spelling mistake.

src/cmd/tools.go Outdated Show resolved Hide resolved
@jeff-mccoy
Copy link
Member Author

In fact sbom might make more sense and syft as the alias as we did with k9s iirc

@jeff-mccoy
Copy link
Member Author

Awesome, thanks for finishing that up.

@Racer159
Copy link
Contributor

Racer159 commented Sep 7, 2022

@jeff-mccoy I fixed the root examples but we may want to fix the sub command examples as well (looks like this would require looping through the cobra child commands and fixing them manually)

@jeff-mccoy
Copy link
Member Author

I think elsewhere we just didn't include the vendored-in examples, I think it might be fine to leave them off as it's more a power-user feature and not really our commands anyway.

@Racer159
Copy link
Contributor

Racer159 commented Sep 8, 2022

Removed the sub command examples. Left the high-level examples just as a quick start for folks

@jeff-mccoy jeff-mccoy merged commit 13612b1 into master Sep 8, 2022
@jeff-mccoy jeff-mccoy deleted the vendor-syft branch September 8, 2022 07:08
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
* vendor syft/migrate witness -> syft direct
* Update examples and docs
* dropping the flake-tastic rhel runner test

Co-authored-by: Wayne Starr <me@racer159.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants