Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for concurrency option when running locally #107

Closed
wants to merge 1 commit into from

Conversation

daguej
Copy link
Contributor

@daguej daguej commented Nov 9, 2023

Fixes #106 by adding an in-memory queue for function invocations.

Copy link

changeset-bot bot commented Nov 9, 2023

⚠️ No Changeset found

Latest commit: 99cead6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -139,6 +107,8 @@ export type Concurrency = Range<0, 51>;
export type NextRouteString = `/api/${string}`;

export interface Manifest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Manifest type must not be extended for local-only features. I suggest creating a new type that extends this one.

};
const fns: Record<string, FunctionConfiguration<any>> = {};

export function setupFn<F extends DeferableFunction>(metadata: Manifest) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps 'registerFunction' would be a more suitable name in this case.

@gearnode
Copy link
Member

@daguej thank you for submitting the issue and pull request. Your work is great! I just have a couple of comments.

@daguej
Copy link
Contributor Author

daguej commented Nov 21, 2023

@gearnode FYI I will not have any additional time to dedicate to working on this.

I encourage your team to take this branch and get it over the finish line.

@codenem codenem self-assigned this Jan 2, 2024
@charlypoly charlypoly assigned charlypoly and unassigned codenem Jan 15, 2024
@charlypoly
Copy link
Contributor

@daguej I continue your PR here: #115

@charlypoly charlypoly closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrency option ignored in local dev
4 participants