Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip out the summary JSON in the markdown of the fixtures? #127

Closed
orta opened this issue Jul 7, 2020 · 1 comment · Fixed by #132
Closed

Strip out the summary JSON in the markdown of the fixtures? #127

orta opened this issue Jul 7, 2020 · 1 comment · Fixed by #132

Comments

@orta
Copy link
Contributor

orta commented Jul 7, 2020

This would mean PRs have smaller diffs in general, and knowing that the JSON is in there is never actually something we're testing in reality.
@elibarzilay
Copy link
Contributor

Whew, I wanted to ask you about doing that...

@elibarzilay elibarzilay mentioned this issue Jul 8, 2020
Merged
@orta orta closed this as completed in #132 Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scrub diagnostics in markdown in json test files
2 participants
@orta @elibarzilay