Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Bot sometimes double-comments #43

Closed
andrewbranch opened this issue Apr 30, 2020 · 3 comments · Fixed by #47
Closed

Bot sometimes double-comments #43

andrewbranch opened this issue Apr 30, 2020 · 3 comments · Fixed by #47

Comments

@andrewbranch
Copy link
Member

Seeing this a good bit but not 100% of the time. Haven’t figured out the culprit yet as I haven’t reproduced in a test. DefinitelyTyped/DefinitelyTyped#44168 (comment)
@andrewbranch
Copy link
Member Author

Or triple- or quadruple-comments? DefinitelyTyped/DefinitelyTyped#43695 (comment)

image

@orta
Copy link
Contributor

orta commented Apr 30, 2020

Ouch, all in the same minute too - I think we need a 0-1500ms delay maybe

@andrewbranch
Copy link
Member Author

Ohhh, so your theory is the bot is commenting, which triggers the webhook, and maybe it queries GH again so fast that the GraphQL response doesn’t yet include the latest comment

@andrewbranch andrewbranch mentioned this issue Apr 30, 2020
Merged
@orta orta closed this as completed in #47 Apr 30, 2020
This was referenced May 1, 2020
Open
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don’t process anything when the webhook is triggered by typescript-bot DefinitelyTyped/dt-mergebot
2 participants
@orta @andrewbranch