[#68] Add attribute type #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 5, 2018 18:48
To be able to use types in attribute, we must include them into AST. This commit does the following: * Add attribute `AttributeDefinition.typeName` * Update parser to set the value in from Definiti code * Update json serialization to accept the new attribute * Add a test to check the presence of the new attribute * Correct existing tests with an empty `typeName`
Now that we can define an attribute type, we should be able to reference it for another attribute. This commit does the following: * Attribute type references can be a dotted String (ex: "abc.def") * Attribute types are considered as Simplified alias types * Imports impact only on the first element of a dotted string * Add tests verifying that attribute type references can reference another attribute type * Add a test verifying imports across packages for several levels
With the new feature, we saw that there was no control over parameter types of named functions. So we add the control in the process. We also add tests to check the new feature (using attribute types). This commit does the following: * Add control `NamedFunctionParameterTypeControl` * Test nominal cases * Test the new feature
…comparisons We check that the new feature behave correctly with comparisons. To do so, we add tests. The feature is already implemented with previous commit. We encounter an invalid case in attribute expression typing with the new feature. We take this opportunity to correct it. This commit does the following: * Correct the type of an attribute expression * Test the new feature for comparisons
…e type name Each attribute type name must be unique. So we add a control to ensure it. This commit does the following: * Add a control verifying the attribute type name uniqueness * Add tests verifying the new control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR give the developer the mean to create a type when creating an attribute.
See commits for more information.
This PR resolves #68.