[#64] Split type Number #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 11, 2018 21:14
Adding some tests, we saw that the symbol `/` did not work. The reason comes from `contextContentSymbol` that redefined `/` instead of using `CALCULATOR_OPERATOR_LEVEL_1` only. This created an identifier in antlr incompatible with `CALCULATOR_OPERATOR_LEVEL_1`. This commit does the following: - Remove usage of `/` in `contextContentSymbol`
To be more robust and keep a logic in our code, split the type `Number`. This change imply to correct lot of tests to consider the new types. However, the production code was not a big change. This commit does the following: * Correct antlr definition to identify both integers and numbers * Create type `IntegerValue` to recognize an integer instead of a number * Rename controls `CalculatorOperandsAreNumber` and `OrderOperandsAreNumber` to be more expressive * Calculator and orders must be on the same numeric type to avoid risks in target languages * Correct tests to use the right numeric type when there was a confusion between the two * Add test ensuring that the same numeric type is used in calculator and order expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be more robust and keep a logic in our code, split the type
Number.This change imply to correct lot of tests to consider the new types.
However, the production code was not a big change.
This commit does the following:
IntegerValueto recognize an integer instead of a numberCalculatorOperandsAreNumberandOrderOperandsAreNumberto be more expressiveThis PR resolves #64.