-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: correctly trigger warnings when matched text is on separate lines
Match was occurring on separate lines because we were searching across the entire container div rather than the individual divs that each line in the mssage is made up of. This fix iterates through each childNode (div) of text and identifies a match that way. Note, this doesn't fix the highlighting though of phrases that span multiple lines.
- Loading branch information
James Duffy
committed
Jan 29, 2021
1 parent
836f1f1
commit 857847b
Showing
2 changed files
with
26 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters