Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umlaut not working when typing with alt+u on mac #25

Closed
WolfgangD opened this issue Jan 13, 2016 · 5 comments
Closed

Umlaut not working when typing with alt+u on mac #25

WolfgangD opened this issue Jan 13, 2016 · 5 comments

Comments

@WolfgangD
Copy link

I need to type emails in German and English equally often on an English keyboard layout. Typing umlauts via ALT+u and e.g. u for ü is broken when enabling the extension.

Steps

  1. Open new email with enabled just not sorry extension
  2. Type alt+u to get ¨ and any of the following characters a, u, o

Expected
¨ will be replaced with ü when typing u

Actual
¨ will not be replaced and the characters appear as: ¨u

@tami-cyrus
Copy link

Sorry to hear that. We'll see if we can fix this in the next update.

Tami Reiss
CEO
Cyrus Innovation http://www.cyrusinnovation.com/
212-647-7186

Agile Reinforcement to accelerate your development

Dedicated to respect and diversity

@tamireiss / @cyrusinnovation

Learn about the difference between the Cyrus way
http://www.cyrusinnovation.com/differences-between-xp-vs-scrum-agile/ and
other consultancies.

On Wed, Jan 13, 2016 at 10:43 AM, Wolfgang notifications@github.com wrote:

I need to type emails in German and English equally often on an English
keyboard layout Typing umlauts via ALT+u and eg u for ü is broken when
enabling the extension

Steps
1 Open new email with enabled just not sorry extension
2 Type alt+u to get ¨ and any of the following characters a, u, o

Expected
¨ will be replaced with ü when typing u

Actual
¨ will not be replaced and the characters appear as: ¨u


Reply to this email directly or view it on GitHub
#25.

@WolfgangD WolfgangD reopened this Jan 13, 2016
sbrudz added a commit that referenced this issue Jan 27, 2016
Currently only "just" is highlighted

Goal is to fix issues #10, #12, #25, #27 by using a different approach
@sbrudz
Copy link
Contributor

sbrudz commented Jan 27, 2016

@WolfgangD I did some testing of the changes in PR #26 and found that, unfortunately, they are broken by changes to the cursor positioning logic in the 0.2.6 release that fixed other bugs. The cursor positioning has been a major source of issues, so we're working on redesigning the way just-not-sorry does highlighting.

@WolfgangD
Copy link
Author

@sbrudz that's sounds like a good plan. I don't expect any problems with modifier characters once the cursor isn't changed during the highlight process.

How long do you expect until those changes will make it into master? I can probably spare some time to try fix it again for 0.2.6 and submit another pull request. Though, I think it is best to wait for the redesign before spending more time on fixing "the old way".

@sbrudz
Copy link
Contributor

sbrudz commented Jan 27, 2016

@WolfgangD Thank you for your offer and for your patience. I recommend waiting for the redesign. I've got a POC working. See #31 for details. We'll update the ticket with an estimate on timing.

@tami-cyrus
Copy link

We're hoping that #31 fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants