Go beyond GMail? Internet forms. #4
Comments
|
We opensourced it so that other people could make more tools if they wanted Tami Reiss Agile Reinforcement to accelerate your development Dedicated to respect and diversity Learn about the difference between the Cyrus way On Tue, Dec 29, 2015 at 4:17 PM, Rachel Berry notifications@github.com
|
|
Just tried to use this, but I'm using Inbox, not Gmail. Can this be extended to include Inbox as most people have made the switch? |
|
We opensourced it so that other people could make more tools if they wanted Tami Reiss Agile Reinforcement to accelerate your development Dedicated to respect and diversity Learn about the difference between the Cyrus way On Wed, Dec 30, 2015 at 6:22 PM, jared-di notifications@github.com wrote:
|
|
+1 for expanding the reach of the plugin to all form fields in chrome (like grammarly) and not just gmail. I use the gmail inbox client which is unsupported by this by default. |
|
We're excited that you want to use Just Not Sorry. The plans for what comes next haven't been decided yet. We have a lot of requests to build something similar for Outlook and Mobile. If we figure out the most user friendly way to do mobile, that should help with inbox a little bit. Additionally, we open sourced the code so if anyone else wanted to expand it for Inbox, they could. We'll keep you posted whatever direction is chosen. Happy new year! Tami Reiss Sent from a device smarter than a third grader, but with equally bad spelling habits.
|
|
@tami-cyrus so to clarify, if I set up a PR for inbox support, could it be accepted and merged, or would you rather have it published separately? |
|
Could be merged. Tami Reiss Sent from a device smarter than a third grader, but with equally bad spelling habits.
|
|
@TheWrongAlice I'm organizing the roadmap for JustNotSorry and since Inbox support is one of our top requested features, I'd like to line it up for the next major release. Have you had a chance to work on a PR? If you have work in progress, I'm happy to review the PR or discuss design ideas. |
|
I have not had the chance to start On Tue, Apr 5, 2016 at 4:59 AM Steve Brudz notifications@github.com wrote:
|
|
No worries. I had an idea over the weekend for how to do it using mutation observers. It may or may not work. I'll try a spike on it this week. |
Instead of using Gmail.js, add a DOM Mutation observer on all contenteditable DIVs. Not sure how performance will be. [#4]
|
@kwokster10 Per our conversation, here's the experiment that I started a5dec2c It uses a DOM Mutation observer to look for DIVs marked contenteditable and then applies the JustNotSorry warning checker to it. It doesn't quite work yet but it's a start. In theory, the approach should work for any web page -- inbox, github issues, hotmail. It would also allow us to get rid of the dependencies on jQuery and Gmail.js. My worries about the approach are that it might negatively impact performance or use up a lot of memory. |
|
@sbrudz Yah, mutation observer is bad for performance. There are other third-party grammar checkers out there for chrome that work everywhere. I wonder how they work. |
|
Here's an update on where we're at with this feature request:
For now, we'll need to add support for new sites on a case by case basis. |
This is an awesome idea, thanks for your work on it so far!
Any plans to enable this on things other than GMail?
Like, say, GitHub Issues? 😄
The text was updated successfully, but these errors were encountered: