Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outlook.com support #103

Merged
merged 10 commits into from
Dec 22, 2020
Merged

Add outlook.com support #103

merged 10 commits into from
Dec 22, 2020

Conversation

sbrudz
Copy link
Contributor

@sbrudz sbrudz commented Dec 22, 2020

This PR adds support for using JustNotSorry on outlook.com (aka https://outlook.live.com)

Fixes #102
Fixes #100

to resolve issues with starting up dev version of extension
This prevents a race condition in start:firefox and start:chrome where the web-ext command would run
prior to webpack causing an error
Change JustNotSorry tests so that nodes are unmounted after each test to prevent test pollution
between test cases
outlook.live.com contenteditable divs have no id prop unlike gmail, so this change adds support for
that case
@sbrudz sbrudz self-assigned this Dec 22, 2020
@sbrudz sbrudz removed the request for review from steveatdm December 22, 2020 14:54
@sbrudz sbrudz merged commit 4fc4366 into beta Dec 22, 2020
@sbrudz sbrudz deleted the add-outlook-support branch December 22, 2020 15:00
@github-actions
Copy link

🎉 This PR is included in version 2.0.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.1.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for outlook.com
1 participant